Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1031253003: Move credential_manager_types.h to components/password_manager/core. (Closed)

Created:
5 years, 9 months ago by dconnelly
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move credential_manager_types.h to components/password_manager/core. This makes it possible to use the types it contains in non-Blink embedders such as iOS. The blink::WebCredential constructor of CredentialInfo is now a factory function that stayed in content/. BUG=470815 TBR=jochen Committed: https://crrev.com/11bdc33e169de972479f1e17e5165776133c04d7 Cr-Commit-Position: refs/heads/master@{#322376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -304 lines) Patch
M chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/account_chooser_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/credential_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/password_manager.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A components/password_manager/content/common/credential_manager_content_utils.h View 1 chunk +22 lines, -0 lines 0 comments Download
A components/password_manager/content/common/credential_manager_content_utils.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M components/password_manager/content/common/credential_manager_messages.h View 1 chunk +1 line, -1 line 0 comments Download
D components/password_manager/content/common/credential_manager_types.h View 1 chunk +0 lines, -74 lines 0 comments Download
D components/password_manager/content/common/credential_manager_types.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D components/password_manager/content/common/credential_manager_types_unittest.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/password_manager/core/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/password_manager/core/common/credential_manager_types.h View 4 chunks +4 lines, -10 lines 0 comments Download
A + components/password_manager/core/common/credential_manager_types.cc View 1 chunk +1 line, -22 lines 0 comments Download
A + components/password_manager/core/common/credential_manager_types_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dconnelly
+mkwst to review +jochen for OWNERS approval of mass-rename
5 years, 9 months ago (2015-03-26 10:44:29 UTC) #2
Mike West
LGTM, thanks for factoring this out into a platform-agnostic file.
5 years, 9 months ago (2015-03-26 10:51:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031253003/1
5 years, 9 months ago (2015-03-26 14:00:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 14:04:38 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 14:05:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11bdc33e169de972479f1e17e5165776133c04d7
Cr-Commit-Position: refs/heads/master@{#322376}

Powered by Google App Engine
This is Rietveld 408576698