components/password_manager/content/renderer/credential_manager_client.cc - Issue 1031253003: Move credential_manager_types.h to components/password_manager/core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 1031253003: Move credential_manager_types.h to components/password_manager/core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_types_unittest.cc ('k') | components/password_manager/core/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc

index 7185096ee3c85d54d71a8de6252c72670aa5cb86..9485ed1f4e7fe711d692a57cfd8a0b840f294d93 100644

--- a/components/password_manager/content/renderer/credential_manager_client.cc

+++ b/components/password_manager/content/renderer/credential_manager_client.cc

@@ -4,8 +4,9 @@

#include "components/password_manager/content/renderer/credential_manager_client.h"

+#include "components/password_manager/content/common/credential_manager_content_utils.h"

#include "components/password_manager/content/common/credential_manager_messages.h"

-#include "components/password_manager/content/common/credential_manager_types.h"

+#include "components/password_manager/core/common/credential_manager_types.h"

#include "content/public/renderer/render_view.h"

#include "third_party/WebKit/public/platform/WebCredential.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerError.h"

@@ -116,7 +117,7 @@ void CredentialManagerClient::dispatchFailedSignIn(

const blink::WebCredential& credential,

blink::WebCredentialManagerClient::NotificationCallbacks* callbacks) {

int request_id = failed_sign_in_callbacks_.Add(callbacks);

- CredentialInfo info(credential);

+ CredentialInfo info(WebCredentialToCredentialInfo(credential));

Send(new CredentialManagerHostMsg_NotifyFailedSignIn(

routing_id(), request_id, info));

}

@@ -125,7 +126,7 @@ void CredentialManagerClient::dispatchSignedIn(

const blink::WebCredential& credential,

blink::WebCredentialManagerClient::NotificationCallbacks* callbacks) {

int request_id = signed_in_callbacks_.Add(callbacks);

- CredentialInfo info(credential);

+ CredentialInfo info(WebCredentialToCredentialInfo(credential));

Send(new CredentialManagerHostMsg_NotifySignedIn(

routing_id(), request_id, info));

}