Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index 9a03243702d2530a22266d8d7b62bf2c3eeabd68..9e787f531165c19493c4f0f11ec4032701b04cbf 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -12,7 +12,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
-#include "base/prefs/pref_member.h"
#include "base/stl_util.h"
#include "components/autofill/core/common/password_form.h"
#include "components/autofill/core/common/password_form_fill_data.h"
@@ -60,12 +59,6 @@ class PasswordManager : public LoginModel {
// should always be valid when called.
void AddSubmissionCallback(const PasswordSubmittedCallback& callback);
- // Is saving new data for password autofill enabled for the current profile
- // and page? For example, saving new data is disabled in Incognito mode,
- // whereas filling data is not. Also, saving data is disabled in the presence
- // of SSL errors on a page.
- bool IsSavingEnabledForCurrentPage() const;
-
// Called by a PasswordFormManager when it decides a form can be autofilled
// on the page.
virtual void Autofill(password_manager::PasswordManagerDriver* driver,
@@ -133,11 +126,6 @@ class PasswordManager : public LoginModel {
MAX_FAILURE_VALUE
};
- // Returns if the password manager is enabled for this page. There are certain
- // situations (e.g. bad SSL cert) where we disable the password manager
- // temporarily.
- bool IsEnabledForCurrentPage() const;
-
// Log failure for UMA. Logs additional metrics if the |form_origin|
// corresponds to one of the top, explicitly monitored websites. For some
// values of |failure| also sends logs to the internals page through |logger|,
@@ -193,10 +181,6 @@ class PasswordManager : public LoginModel {
// The embedder-level client. Must outlive this class.
PasswordManagerClient* const client_;
- // Set to false to disable password saving (will no longer ask if you
- // want to save passwords but will continue to fill passwords).
- BooleanPrefMember saving_passwords_enabled_;
-
// Observers to be notified of LoginModel events. This is mutable to allow
// notification in const member functions.
mutable ObserverList<LoginModelObserver> observers_;

Powered by Google App Engine
This is Rietveld 408576698