components/password_manager/core/browser/password_generation_manager_unittest.cc - Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_generation_manager.cc ('k') | components/password_manager/core/browser/password_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc

index 97913e2dfe4bea533c1f6ddb9254c4e22506539e..d01d5f52488cb5534ec8706bbd7c789ca60fe385 100644

--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc

@@ -123,8 +123,8 @@ class PasswordGenerationManagerTest : public testing::Test {

TEST_F(PasswordGenerationManagerTest, IsGenerationEnabled) {

// Enabling the PasswordManager and password sync should cause generation to

// be enabled.

- PrefService* prefs = client_->GetPrefs();

- prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, true);

+ EXPECT_CALL(*client_, IsSavingEnabledForCurrentPage())

+ .WillRepeatedly(testing::Return(true));

EXPECT_CALL(*client_, IsPasswordSyncEnabled(_))

.WillRepeatedly(testing::Return(true));

EXPECT_TRUE(IsGenerationEnabled());

@@ -136,7 +136,8 @@ TEST_F(PasswordGenerationManagerTest, IsGenerationEnabled) {

// Disabling the PasswordManager should cause generation to be disabled even

// if syncing is enabled.

- prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, false);

+ EXPECT_CALL(*client_, IsSavingEnabledForCurrentPage())

+ .WillRepeatedly(testing::Return(false));

EXPECT_CALL(*client_, IsPasswordSyncEnabled(_))

.WillRepeatedly(testing::Return(true));

EXPECT_FALSE(IsGenerationEnabled());

@@ -144,8 +145,8 @@ TEST_F(PasswordGenerationManagerTest, IsGenerationEnabled) {

TEST_F(PasswordGenerationManagerTest, DetectAccountCreationForms) {

// Setup so that IsGenerationEnabled() returns true.

- PrefService* prefs = client_->GetPrefs();

- prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, true);

+ EXPECT_CALL(*client_, IsSavingEnabledForCurrentPage())

+ .WillRepeatedly(testing::Return(true));

EXPECT_CALL(*client_, IsPasswordSyncEnabled(_))

.WillRepeatedly(testing::Return(true));