components/password_manager/core/browser/password_generation_manager.cc - Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager.cc

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/save_password_progress_logger.cc ('K') | « components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc ('k') | components/password_manager/core/browser/password_generation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager.cc

diff --git a/components/password_manager/core/browser/password_generation_manager.cc b/components/password_manager/core/browser/password_generation_manager.cc

index 638822b877ea66acb10772b898ec4d4a6df1985e..fcb9f0af03d88113b94a610c7d3ce22bad2b10a1 100644

--- a/components/password_manager/core/browser/password_generation_manager.cc

+++ b/components/password_manager/core/browser/password_generation_manager.cc

@@ -51,7 +51,7 @@ void PasswordGenerationManager::DetectAccountCreationForms(

// (1) Password sync is enabled, and

// (2) Password saving is enabled.

bool PasswordGenerationManager::IsGenerationEnabled() const {

- if (!driver_->GetPasswordManager()->IsSavingEnabledForCurrentPage()) {

+ if (!client_->IsSavingEnabledForCurrentPage()) {

VLOG(2) << "Generation disabled because password saving is disabled";

return false;

}