components/autofill/core/common/save_password_progress_logger.cc - Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/content/browser/credential_manager_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 098c6e201ea84e62f91d94b22ef3ce7fdd260a0d..0aa688392a6eea01d1fa7782ee2381e37db8ae2b 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -201,9 +201,8 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {

return "Number of pending login managers (before)";

case SavePasswordProgressLogger::STRING_NEW_NUMBER_LOGIN_MANAGERS:

return "Number of pending login managers (after)";

- case SavePasswordProgressLogger::STRING_ENABLED_FOR_CURRENT_PAGE_METHOD:

- return "PasswordManager::IsEnabledForCurrentPage";

- case SavePasswordProgressLogger::STRING_CLIENT_CHECK_PRESENT:

+ case SavePasswordProgressLogger::

+ STRING_PASSWORD_MANAGEMENT_ENABLED_FOR_CURRENT_PAGE:

return "IsPasswordManagerEnabledForCurrentPage";

vabr (Chromium) 2015/04/07 13:53:15 typo: Manager -> Management ?

melandory 2015/04/07 14:28:52 Done.

case SavePasswordProgressLogger::STRING_SHOW_LOGIN_PROMPT_METHOD:

return "ShowLoginPrompt";