Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031133003: favor DCHECK_CURRENTLY_ON for better logs in content/browser (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, creis+watch_chromium.org, eme-reviews_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in content/browser BUG=466848 Committed: https://crrev.com/366eaf1d53e51685c382749f5bda16ce0bfa37ad Cr-Commit-Position: refs/heads/master@{#322280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Avi: please take a look.
5 years, 9 months ago (2015-03-25 19:58:15 UTC) #2
Avi (use Gerrit)
lgtm That works.
5 years, 9 months ago (2015-03-25 20:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031133003/1
5 years, 9 months ago (2015-03-25 20:44:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 00:51:25 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:52:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/366eaf1d53e51685c382749f5bda16ce0bfa37ad
Cr-Commit-Position: refs/heads/master@{#322280}

Powered by Google App Engine
This is Rietveld 408576698