Issue 1031083004: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/custom_handlers/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1031083004: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/custom_handlers/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore

Modified:
5 years, 8 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, vabr (Chromium)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/custom_handlers/ BUG=466848 Committed: https://crrev.com/2de201373cbd45ba68198392c29aa7c0076ccb63 Cr-Commit-Position: refs/heads/master@{#326120}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -48 lines)			Patch
	M	chrome/browser/custom_handlers/protocol_handler_registry.cc	View		37 chunks	+44 lines, -44 lines	0 comments	Download
	M	chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031083004/20001

5 years, 8 months ago (2015-04-21 20:18:06 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-21 21:20:37 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/2de201373cbd45ba68198392c29aa7c0076ccb63
Cr-Commit-Position: refs/heads/master@{#326120}