Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5390)

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 1031083004: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/custom_handlers/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
index ffdf7dee510079470020bf1adf7bdc86888944ec..61da17f67460061e49590b82cb536ed26ef099ed 100644
--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
@@ -34,7 +34,7 @@ namespace {
void AssertInterceptedIO(
const GURL& url,
net::URLRequestJobFactory* interceptor) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
net::URLRequestContext context;
scoped_ptr<net::URLRequest> request(context.CreateRequest(
url, net::DEFAULT_PRIORITY, NULL));
@@ -47,7 +47,7 @@ void AssertInterceptedIO(
void AssertIntercepted(
const GURL& url,
net::URLRequestJobFactory* interceptor) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(BrowserThread::IO,
FROM_HERE,
base::Bind(AssertInterceptedIO,
@@ -96,7 +96,7 @@ void AssertWillHandleIO(
const std::string& scheme,
bool expected,
ProtocolHandlerRegistry::JobInterceptorFactory* interceptor) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
interceptor->Chain(scoped_ptr<net::URLRequestJobFactory>(
new FakeURLRequestJobFactory()));
ASSERT_EQ(expected, interceptor->IsHandledProtocol(scheme));
@@ -107,7 +107,7 @@ void AssertWillHandle(
const std::string& scheme,
bool expected,
ProtocolHandlerRegistry::JobInterceptorFactory* interceptor) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(BrowserThread::IO,
FROM_HERE,
base::Bind(AssertWillHandleIO,
« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698