Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1031063002: Cache Storage: Implement Blink Platform API (Closed)

Created:
5 years, 9 months ago by jsbell
Modified:
5 years, 9 months ago
Reviewers:
kinuko, michaeln, jam
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache Storage: Implement Blink Platform API The API will be defined in a follow-up Blink CL. Unlike the existing, Service Worker-specific API, this one passes ownership of the new object to the caller. The origin is specified by a database identifier derived from the SecurityOrigin on the Blink side. BUG=439389 Committed: https://crrev.com/555f534f8262449d2bff2abdd635a6ada4cd9f9e Cr-Commit-Position: refs/heads/master@{#322278}

Patch Set 1 #

Patch Set 2 : Add TODO about cleanup #

Total comments: 2

Patch Set 3 : Better name for origin arg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/renderer/renderer_blink_platform_impl.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jsbell
Blink side is https://codereview.chromium.org/1029423004 Since it's easiest, my plan is to land this CL first, ...
5 years, 9 months ago (2015-03-24 23:10:22 UTC) #2
michaeln
lgtm
5 years, 9 months ago (2015-03-24 23:44:47 UTC) #3
michaeln
https://codereview.chromium.org/1031063002/diff/20001/content/renderer/renderer_blink_platform_impl.h File content/renderer/renderer_blink_platform_impl.h (right): https://codereview.chromium.org/1031063002/diff/20001/content/renderer/renderer_blink_platform_impl.h#newcode106 content/renderer/renderer_blink_platform_impl.h:106: const blink::WebString& identifier); 'origin_identifier' for clarity?
5 years, 9 months ago (2015-03-24 23:57:34 UTC) #4
kinuko
lgtm
5 years, 9 months ago (2015-03-25 03:50:03 UTC) #5
jsbell
https://codereview.chromium.org/1031063002/diff/20001/content/renderer/renderer_blink_platform_impl.h File content/renderer/renderer_blink_platform_impl.h (right): https://codereview.chromium.org/1031063002/diff/20001/content/renderer/renderer_blink_platform_impl.h#newcode106 content/renderer/renderer_blink_platform_impl.h:106: const blink::WebString& identifier); On 2015/03/24 23:57:34, michaeln wrote: > ...
5 years, 9 months ago (2015-03-25 16:27:40 UTC) #6
jsbell
jam@ - can you review the renderer_blink_platform_impl.* changes?
5 years, 9 months ago (2015-03-25 16:30:35 UTC) #8
jam
lgtm
5 years, 9 months ago (2015-03-25 16:35:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031063002/40001
5 years, 9 months ago (2015-03-25 23:17:47 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-26 00:39:23 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:40:47 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/555f534f8262449d2bff2abdd635a6ada4cd9f9e
Cr-Commit-Position: refs/heads/master@{#322278}

Powered by Google App Engine
This is Rietveld 408576698