Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1029423004: Cache Storage: Add Platform API to retrieve CacheStorage for origin (Closed)

Created:
5 years, 9 months ago by jsbell
Modified:
5 years, 9 months ago
Reviewers:
kinuko, michaeln, dglazkov, tkent
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cache Storage: Add Platform API to retrieve CacheStorage for origin Define a public API to allow any execution context, not just a Service Worker, to access the Cache Storage system. Switch Service Workers (and SW devtools) over to using it, and drop the old public API. No other contexts are given access to it, so there is no change in functionality exposed to script. BUG=439389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192588

Patch Set 1 #

Total comments: 7

Patch Set 2 : Remove cruft, rename arg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M Source/modules/serviceworkers/CacheStorage.h View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp View 5 chunks +11 lines, -13 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/Platform.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
jsbell
Chromium side is https://codereview.chromium.org/1031063002/ Since it's easiest, my plan is to land that other CL ...
5 years, 9 months ago (2015-03-24 23:11:23 UTC) #2
michaeln
lgtm 2 https://codereview.chromium.org/1029423004/diff/1/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp File Source/web/ServiceWorkerGlobalScopeClientImpl.cpp (right): https://codereview.chromium.org/1029423004/diff/1/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp#newcode35 Source/web/ServiceWorkerGlobalScopeClientImpl.cpp:35: #include "public/platform/Platform.h" what pulled the new includes ...
5 years, 9 months ago (2015-03-25 00:12:35 UTC) #3
kinuko
lgtm https://codereview.chromium.org/1029423004/diff/1/Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp File Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp (right): https://codereview.chromium.org/1029423004/diff/1/Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp#newcode308 Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp:308: OwnPtr<WebServiceWorkerCacheStorage> cache = assertCacheStorage(errorString, m_globalScope); Oh ok- so ...
5 years, 9 months ago (2015-03-25 03:57:23 UTC) #4
jsbell
https://codereview.chromium.org/1029423004/diff/1/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp File Source/web/ServiceWorkerGlobalScopeClientImpl.cpp (right): https://codereview.chromium.org/1029423004/diff/1/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp#newcode35 Source/web/ServiceWorkerGlobalScopeClientImpl.cpp:35: #include "public/platform/Platform.h" On 2015/03/25 00:12:35, michaeln wrote: > what ...
5 years, 9 months ago (2015-03-25 16:25:52 UTC) #5
jsbell
dglazkov@ - can you OWNERS review the public and Source/web changes?
5 years, 9 months ago (2015-03-25 16:29:51 UTC) #7
michaeln
https://codereview.chromium.org/1029423004/diff/1/Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp File Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp (right): https://codereview.chromium.org/1029423004/diff/1/Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp#newcode308 Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp:308: OwnPtr<WebServiceWorkerCacheStorage> cache = assertCacheStorage(errorString, m_globalScope); On 2015/03/25 03:57:23, kinuko ...
5 years, 9 months ago (2015-03-25 18:52:24 UTC) #8
jsbell
Since dglazkov@ is busy being famous today, adding tkent@ as another possible public/ and Source/web ...
5 years, 9 months ago (2015-03-25 23:08:14 UTC) #10
tkent
lgtm
5 years, 9 months ago (2015-03-25 23:15:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029423004/20001
5 years, 9 months ago (2015-03-25 23:15:51 UTC) #14
jsbell
Whoops, chromium side has to land first. Was just waiting on this getting reviewed. Sorry ...
5 years, 9 months ago (2015-03-25 23:17:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029423004/20001
5 years, 9 months ago (2015-03-26 00:48:04 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/56542)
5 years, 9 months ago (2015-03-26 03:37:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029423004/20001
5 years, 9 months ago (2015-03-26 03:38:36 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/56583)
5 years, 9 months ago (2015-03-26 05:03:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029423004/20001
5 years, 9 months ago (2015-03-26 05:04:14 UTC) #26
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 07:56:24 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192588

Powered by Google App Engine
This is Rietveld 408576698