Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 1030723003: postmortem: fixup after 33994b4

Created:
5 years, 9 months ago by indutny
Modified:
5 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

postmortem: fixup after 33994b4 This commit has changed the enum names: 33994b4a22834efb26620ffa3053a5d15d48a6bd `FIELD` is now called `DATA`. BUG= R=danno

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
indutny
Hello! This was required to make postmortem work in io.js :) Sorry for sending this ...
5 years, 9 months ago (2015-03-23 20:37:21 UTC) #1
danno
lgtm
5 years, 9 months ago (2015-03-24 08:23:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030723003/1
5 years, 9 months ago (2015-03-24 08:23:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1468)
5 years, 9 months ago (2015-03-24 08:26:16 UTC) #6
danno
You have to use your "fedor@indutny.com" address to submit that patch, since that's the one ...
5 years, 9 months ago (2015-03-24 08:33:09 UTC) #7
indutny
5 years, 9 months ago (2015-03-24 19:43:35 UTC) #8
Gosh, sorry for this. Here you go https://codereview.chromium.org/1033733003,
feel free to close this CL.

Powered by Google App Engine
This is Rietveld 408576698