Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033733003: postmortem: fixup after 33994b4 (Closed)

Created:
5 years, 9 months ago by fedor.indutny
Modified:
5 years, 9 months ago
Reviewers:
danno, indutny
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

postmortem: fixup after 33994b4 This commit has changed the enum names: 33994b4a22834efb26620ffa3053a5d15d48a6bd `FIELD` is now called `DATA`. BUG= R=danno Committed: https://crrev.com/93a290d0ff4a81cac9a7dcac982e46b3909d6ca9 Cr-Commit-Position: refs/heads/master@{#27434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
indutny
Old CL: https://codereview.chromium.org/1030723003/
5 years, 9 months ago (2015-03-24 19:43:52 UTC) #2
danno
lgtm
5 years, 9 months ago (2015-03-25 09:45:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033733003/1
5 years, 9 months ago (2015-03-25 09:47:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 10:10:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/93a290d0ff4a81cac9a7dcac982e46b3909d6ca9 Cr-Commit-Position: refs/heads/master@{#27434}
5 years, 9 months ago (2015-03-25 10:10:12 UTC) #7
indutny
5 years, 9 months ago (2015-03-25 20:08:21 UTC) #8
Message was sent while issue was closed. 
Thank you!

Powered by Google App Engine
This is Rietveld 408576698