ServiceWorker: Add UMA for storage recovery operation

ServiceWorker: Add UMA for storage recovery operation

This CL adds UMA for results of SWStorage::DeleteAndStartOver() and
SWDatabase::DestroyDatabase(). Deleting the diskcache just returns
success/failure boolean and it will be recorded as a part of results
of DeleteAndStartOver().

BUG=461654, 468926
TEST=n/a

Committed: https://crrev.com/d954a0c1c36eb49a9aed3595157992b5f656c3b6
Cr-Commit-Position: refs/heads/master@{#322332}

[nhiroki, 2015-03-24 01:53:41]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-03-24 01:58:11]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org, michaeln@chromium.org

[nhiroki, 2015-03-24 01:58:11]

Hi, can you review this? Thanks!

[falken, 2015-03-24 08:15:58]

lgtm

[michaeln, 2015-03-25 00:39:43]

lgtm

[nhiroki, 2015-03-25 03:25:20]

nhiroki@chromium.org changed reviewers:
+ isherman@chromium.org

[nhiroki, 2015-03-25 03:25:20]

+isherman@, would you review histograms.xml?

[Ilya Sherman, 2015-03-25 20:45:08]

LGTM

https://codereview.chromium.org/1030703003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/1030703003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:54: void
ServiceWorkerMetrics::CountWriteDatabaseResult(
Why have you removed the "// static" comments?  They're used pretty consistently
throughout the Chromium codebase.  (Note: I don't feel strongly about this.)

[nhiroki, 2015-03-25 23:08:08]

Thank you for reviewing!

https://codereview.chromium.org/1030703003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/1030703003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:54: void
ServiceWorkerMetrics::CountWriteDatabaseResult(
On 2015/03/25 20:45:08, Ilya Sherman wrote:
> Why have you removed the "// static" comments?  They're used pretty
consistently
> throughout the Chromium codebase.  (Note: I don't feel strongly about this.)

I think such comments aren't informative in this class because this is designed
to contain only static functions and annotated with
DISALLOW_IMPLICIT_CONSTRUCTORS().

[nhiroki, 2015-03-25 23:08:15]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-03-25 23:09:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030703003/20001

[commit-bot: I haz the power, 2015-03-26 02:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 02:27:50]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nhiroki, 2015-03-26 04:24:18]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-03-26 04:24:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030703003/20001

[commit-bot: I haz the power, 2015-03-26 06:10:14]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-03-26 06:10:51]

Patchset 1 (id:??) landed as
https://crrev.com/d954a0c1c36eb49a9aed3595157992b5f656c3b6
Cr-Commit-Position: refs/heads/master@{#322332}