Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: content/browser/service_worker/service_worker_storage.cc

Issue 1030703003: ServiceWorker: Add UMA for storage recovery operation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_storage.cc
diff --git a/content/browser/service_worker/service_worker_storage.cc b/content/browser/service_worker/service_worker_storage.cc
index 3b37e233a328c915e346967c1536959cde501754..e84bd49382d71690b92c41b91636981fd47ed0f6 100644
--- a/content/browser/service_worker/service_worker_storage.cc
+++ b/content/browser/service_worker/service_worker_storage.cc
@@ -1756,6 +1756,8 @@ void ServiceWorkerStorage::DidDeleteDatabase(
// Give up the corruption recovery until the browser restarts.
LOG(ERROR) << "Failed to delete the database: "
<< ServiceWorkerDatabase::StatusToString(status);
+ ServiceWorkerMetrics::RecordDeleteAndStartOverResult(
+ ServiceWorkerMetrics::DELETE_DATABASE_ERROR);
callback.Run(DatabaseStatusToStatusCode(status));
return;
}
@@ -1780,10 +1782,14 @@ void ServiceWorkerStorage::DidDeleteDiskCache(
if (!result) {
// Give up the corruption recovery until the browser restarts.
LOG(ERROR) << "Failed to delete the diskcache.";
+ ServiceWorkerMetrics::RecordDeleteAndStartOverResult(
+ ServiceWorkerMetrics::DELETE_DISK_CACHE_ERROR);
callback.Run(SERVICE_WORKER_ERROR_FAILED);
return;
}
DVLOG(1) << "Deleted ServiceWorkerDiskCache successfully.";
+ ServiceWorkerMetrics::RecordDeleteAndStartOverResult(
+ ServiceWorkerMetrics::DELETE_OK);
callback.Run(SERVICE_WORKER_OK);
}

Powered by Google App Engine
This is Rietveld 408576698