Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 103053006: Renaming NativeMessagingHost to Me2MeNativeMessagingHost. (Closed)

Created:
7 years ago by weitao
Modified:
7 years ago
Reviewers:
Sergey Ulanov, Jói
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@delegage
Visibility:
Public.

Description

Renamed NativeMessagingHost to Me2MeNativeMessagingHost. Also excluded remoting/host from the _checkSpamLogging PRESUBMIT check. BUG= TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241100

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Resolving merge conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -87 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.h View 2 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.cc View 21 chunks +36 lines, -36 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_unittest.cc View 18 chunks +36 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
weitao
Joi, could you please review the change in PRESUBMIT.py? I found more places in remoting/host ...
7 years ago (2013-12-13 18:08:45 UTC) #1
Sergey Ulanov
LGTM. It might be better to split PRESUBMIT change from the rename. You should still ...
7 years ago (2013-12-13 21:14:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/103053006/20001
7 years ago (2013-12-14 04:35:52 UTC) #3
commit-bot: I haz the power
Failed to apply patch for PRESUBMIT.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-14 04:35:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/103053006/40001
7 years ago (2013-12-15 19:14:17 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204407
7 years ago (2013-12-15 20:48:13 UTC) #6
Jói
PRESUBMIT.py LGTM
7 years ago (2013-12-16 12:28:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/103053006/40001
7 years ago (2013-12-16 23:12:04 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-17 02:05:43 UTC) #9
Message was sent while issue was closed.
Change committed as 241100

Powered by Google App Engine
This is Rietveld 408576698