Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: PRESUBMIT.py

Issue 103053006: Renaming NativeMessagingHost to Me2MeNativeMessagingHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@delegage
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/host/host_main.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 853 matching lines...) Expand 10 before | Expand all | Expand 10 after
864 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS 864 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
865 black_list = (_EXCLUDED_PATHS + 865 black_list = (_EXCLUDED_PATHS +
866 _TEST_CODE_EXCLUDED_PATHS + 866 _TEST_CODE_EXCLUDED_PATHS +
867 input_api.DEFAULT_BLACK_LIST + 867 input_api.DEFAULT_BLACK_LIST +
868 (r"^base[\\\/]logging\.h$", 868 (r"^base[\\\/]logging\.h$",
869 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$", 869 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$",
870 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", 870 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$",
871 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", 871 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*",
872 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" 872 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]"
873 r"logging_native_handler\.cc$", 873 r"logging_native_handler\.cc$",
874 r"^remoting[\\\/]base[\\\/]logging\.h$", 874 r"^remoting[\\\/]host[\\\/].*",
Sergey Ulanov 2013/12/13 21:14:07 I think we want to keep remoting/base/logging.h it
875 r"^sandbox[\\\/]linux[\\\/].*",)) 875 r"^sandbox[\\\/]linux[\\\/].*",))
876 source_file_filter = lambda x: input_api.FilterSourceFile( 876 source_file_filter = lambda x: input_api.FilterSourceFile(
877 x, white_list=(file_inclusion_pattern,), black_list=black_list) 877 x, white_list=(file_inclusion_pattern,), black_list=black_list)
878 878
879 log_info = [] 879 log_info = []
880 printf = [] 880 printf = []
881 881
882 for f in input_api.AffectedSourceFiles(source_file_filter): 882 for f in input_api.AffectedSourceFiles(source_file_filter):
883 contents = input_api.ReadFile(f, 'rb') 883 contents = input_api.ReadFile(f, 'rb')
884 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): 884 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents):
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
1229 trybots += ['cros_x86'] 1229 trybots += ['cros_x86']
1230 1230
1231 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1231 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1232 # unless they're .gyp(i) files as changes to those files can break the gyp 1232 # unless they're .gyp(i) files as changes to those files can break the gyp
1233 # step on that bot. 1233 # step on that bot.
1234 if (not all(re.search('^chrome', f) for f in files) or 1234 if (not all(re.search('^chrome', f) for f in files) or
1235 any(re.search('\.gypi?$', f) for f in files)): 1235 any(re.search('\.gypi?$', f) for f in files)):
1236 trybots += ['android_aosp'] 1236 trybots += ['android_aosp']
1237 1237
1238 return trybots 1238 return trybots
OLDNEW
« no previous file with comments | « no previous file | remoting/host/host_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698