chrome/browser/devtools/device/usb/android_usb_device.cc - Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_usb_device.cc

Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | chrome/browser/devtools/device/webrtc/devtools_bridge_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/usb/android_usb_device.cc

diff --git a/chrome/browser/devtools/device/usb/android_usb_device.cc b/chrome/browser/devtools/device/usb/android_usb_device.cc

index 0ff40cdb5572143f3f6ee7c63bd469174f619e15..4ced939f631d8a2724ec128f8c07e3f57e386881 100644

--- a/chrome/browser/devtools/device/usb/android_usb_device.cc

+++ b/chrome/browser/devtools/device/usb/android_usb_device.cc

@@ -180,7 +180,7 @@ static void RespondOnFileThread(

const AndroidUsbDevicesCallback& callback,

AndroidUsbDevices* devices,

scoped_refptr<base::MessageLoopProxy> caller_message_loop_proxy) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

caller_message_loop_proxy->PostTask(

FROM_HERE,

base::Bind(&RespondOnCallerThread, callback, devices));

@@ -193,7 +193,7 @@ static void OpenAndroidDeviceOnFileThread(

scoped_refptr<UsbDevice> device,

int interface_id,

bool success) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

if (success) {

base::string16 serial;

if (device->GetSerialNumber(&serial) && !serial.empty()) {

@@ -215,7 +215,7 @@ static void OpenAndroidDeviceOnFileThread(

}

static int CountOnFileThread() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

UsbService* service = device::DeviceClient::Get()->GetUsbService();

UsbDevices usb_devices;

if (service != NULL)

@@ -238,7 +238,7 @@ static void EnumerateOnFileThread(

crypto::RSAPrivateKey* rsa_key,

const AndroidUsbDevicesCallback& callback,

scoped_refptr<base::MessageLoopProxy> caller_message_loop_proxy) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

UsbService* service = device::DeviceClient::Get()->GetUsbService();

UsbDevices usb_devices;

@@ -612,7 +612,7 @@ void AndroidUsbDevice::TransferError(UsbTransferStatus status) {

void AndroidUsbDevice::TerminateIfReleased(

scoped_refptr<UsbDeviceHandle> usb_handle) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

if (usb_handle->GetDevice().get())

return;

message_loop_->PostTask(FROM_HERE,