chrome/browser/devtools/device/usb/android_usb_browsertest.cc - Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/port_forwarding_controller.cc ('k') | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

diff --git a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

index af2dd46d52c65240439df50706854cce5b294fc0..0c96628de1bbdac2731522c9b41a90d8089fab95 100644

--- a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

+++ b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

@@ -586,7 +586,7 @@ class AndroidUsbDiscoveryTest : public InProcessBrowserTest {

}

void ScheduleDeviceCountRequest(const base::Closure& request) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

scheduler_invoked_++;

BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, request);

}

@@ -690,7 +690,7 @@ class MockCountListener : public DevToolsAndroidBridge::DeviceCountListener {

};

void ShutdownOnUIThread() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (reposts_left_-- == 0) {

base::MessageLoop::current()->Quit();

} else {

@@ -703,7 +703,7 @@ class MockCountListener : public DevToolsAndroidBridge::DeviceCountListener {

}

void ShutdownOnFileThread() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

BrowserThread::PostTask(BrowserThread::UI,

FROM_HERE,

base::Bind(&MockCountListener::ShutdownOnUIThread,