Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools

Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore

Modified:
5 years, 9 months ago

Reviewers:
yurys

CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools BUG=466848 Committed: https://crrev.com/13260d5807e1d294e7905f54afe6d92501cee7ee Cr-Commit-Position: refs/heads/master@{#322339}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -87 lines)			Patch
M	chrome/browser/devtools/device/android_device_manager.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/device/android_web_socket.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/devtools/device/devtools_android_bridge.cc	View	19 chunks	+22 lines, -22 lines	0 comments	Download
M	chrome/browser/devtools/device/port_forwarding_controller.cc	View	8 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/devtools/device/usb/android_usb_browsertest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/device/usb/android_usb_device.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/devtools/device/webrtc/devtools_bridge_client.cc	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/devtools/devtools_file_helper.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/devtools/devtools_file_system_indexer.cc	View	14 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/devtools/devtools_target_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/devtools/devtools_targets_ui.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/devtools/devtools_ui_bindings.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030263002/1

5 years, 9 months ago (2015-03-26 08:18:13 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-26 09:13:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/13260d5807e1d294e7905f54afe6d92501cee7ee
Cr-Commit-Position: refs/heads/master@{#322339}