DescriptionFix missing symbols for pre-linking of the Cast sender library for iOS.
When pre-linking the Cast sender library for the iOS simulator, a number
of symbols are reported as undefined, even though the functions using
them are dead code and the whole chain should disappear under dead code
elimination. The same problem does not occur when targetting iOS
hardware, which suggests a bug in the Intel linker.
This patch either defines those missing symbols or prevents their use.
Specifically, the patch adds dummy definitions for native_library and
process_metrics under iOS which do nothing, and disables the assembly
code path in yuv_convert when compiling for iOS (gyp is unable to build
the simd code properly for target_subarch=both). Otherwise yuv_convert
is functional via its normal CPU code path and is added to the
media_for_ios_cast target to support VideoFrame methods.
BUG=470602
R=miu@chromium.org
Committed: https://crrev.com/32be1d41c5fff2548c3dbe7406cc082a78b3a004
Cr-Commit-Position: refs/heads/master@{#323267}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add native_library_ios.mm to base/BUILD.gn. #
Total comments: 6
Patch Set 3 : Review suggestions in native_library_ios. #Patch Set 4 : Document why the create frame methods are not available in media for cast ios. #Patch Set 5 : Add NOTIMPLEMENTED annotations and stub out yuv assembly path on iOS instead of removing VideoFrame… #Patch Set 6 : Import base/logging.h in process_metrics_ios.cc for NOTIMPLEMENTED. #Patch Set 7 : Update media/base/BUILD.gn. #
Messages
Total messages: 29 (4 generated)
|