Issue 1030233002: Remove DVLOG spam and unnecessary StopObserving calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1030233002: Remove DVLOG spam and unnecessary StopObserving calls. (Closed)

Created:
5 years, 9 months ago by davidben

Modified:
5 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove DVLOG spam and unnecessary StopObserving calls. Follow-up to https://codereview.chromium.org/859213006. The DVLOG lines are unnecessary and CertificateSelected implicitly calls StopObserving. BUG=none Committed: https://crrev.com/cb4b2410c1ddd0a784bb24e9cd741534cc8d06f4 Cr-Commit-Position: refs/heads/master@{#322235}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	chrome/browser/ui/views/ssl_client_certificate_selector.cc	View		5 chunks	+0 lines, -8 lines	0 comments	Download

Total messages: 7 (2 generated)

davidben

Some follow-up changes to another CL you requested which I finally remembered to do.

5 years, 9 months ago (2015-03-25 18:23:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030233002/1

5 years, 9 months ago (2015-03-25 20:49:42 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 20:55:43 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cb4b2410c1ddd0a784bb24e9cd741534cc8d06f4
Cr-Commit-Position: refs/heads/master@{#322235}