Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector.cc

Issue 1030233002: Remove DVLOG spam and unnecessary StopObserving calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/ssl_client_certificate_selector.cc
diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.cc b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
index 72f4a4987e73625bfa1549ccf83af84d449bb009..8222614d980fbc6427672ee5ee1debb87ee458b4 100644
--- a/chrome/browser/ui/views/ssl_client_certificate_selector.cc
+++ b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
@@ -6,7 +6,6 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
-#include "base/logging.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/grit/generated_resources.h"
#include "components/web_modal/popup_manager.h"
@@ -30,7 +29,6 @@ SSLClientCertificateSelector::SSLClientCertificateSelector(
SSLClientAuthObserver(web_contents->GetBrowserContext(),
cert_request_info,
delegate.Pass()) {
- DVLOG(1) << __FUNCTION__;
}
SSLClientCertificateSelector::~SSLClientCertificateSelector() {
@@ -44,19 +42,15 @@ void SSLClientCertificateSelector::Init() {
}
void SSLClientCertificateSelector::OnCertSelectedByNotification() {
- DVLOG(1) << __FUNCTION__;
GetWidget()->Close();
}
bool SSLClientCertificateSelector::Cancel() {
- DVLOG(1) << __FUNCTION__;
- StopObserving();
CertificateSelected(nullptr);
return true;
}
bool SSLClientCertificateSelector::Accept() {
- DVLOG(1) << __FUNCTION__;
scoped_refptr<net::X509Certificate> cert = GetSelectedCert();
if (cert.get()) {
// Remove the observer before we try unlocking, otherwise we might act on a
@@ -88,7 +82,6 @@ bool SSLClientCertificateSelector::Close() {
}
void SSLClientCertificateSelector::Unlocked(net::X509Certificate* cert) {
- DVLOG(1) << __FUNCTION__;
CertificateSelected(cert);
GetWidget()->Close();
}
@@ -99,7 +92,6 @@ void ShowSSLClientCertificateSelector(
content::WebContents* contents,
net::SSLCertRequestInfo* cert_request_info,
scoped_ptr<content::ClientCertificateDelegate> delegate) {
- DVLOG(1) << __FUNCTION__ << " " << contents;
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// Not all WebContentses can show modal dialogs.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698