Report error messages to DevTools window.

Report error messages to DevTools window.

This cl depends on https://codereview.chromium.org/1036743003/.

BUG=466871
Committed: https://crrev.com/62b1a31dea0cc9372a4b3dbcdec869929af88cce
Cr-Commit-Position: refs/heads/master@{#322354}

[horo, 2015-03-25 09:47:57]

Patchset #1 (id:1) has been deleted

[horo, 2015-03-25 09:48:39]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2015-03-25 09:48:40]

falken@
Could you please review this?

[horo, 2015-03-25 09:50:30]

horo@chromium.org changed reviewers:
+ dgozman@chromium.org

[horo, 2015-03-25 09:50:30]

dgozman@
Could you please review
content/browser/devtools/protocol/service_worker_handler.h?

[horo, 2015-03-25 09:50:48]

dgozman@
Could you please review
content/browser/devtools/protocol/service_worker_handler.*?

[dgozman, 2015-03-25 10:54:49]

What are the errors reported here? Would it make sense to have a global error
list, so that you can connect after the error has occurred and still get error
report?

I believe similar thing is already implemented for extensions. And regular page
console errors follow this pattern.

[horo, 2015-03-25 14:43:15]

On 2015/03/25 10:54:49, dgozman wrote:
> What are the errors reported here? Would it make sense to have a global error
> list, so that you can connect after the error has occurred and still get error
> report?
> 
> I believe similar thing is already implemented for extensions. And regular
page
> console errors follow this pattern.

The errors are mainly from the ServiceWorker registration procedure.
For example, when "navigator.serviceWorker.register('/sw.js')" is called, and
sw.js has a SyntaxError, the registration procedure will fail.
In this scenario the registration information must be cleared from the memory.
So we can't have a global error list for it.

[falken, 2015-03-26 03:56:29]

sw parts look good

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:776:
OnReportException(base::UTF8ToUTF16(message + ". " + status_message), -1, -1,
The status_message is supposed to be the message to show the user, and we only
fall back to the generic message if it doesn't exist: see
GetServiceWorkerRegistrationStatusResponse and ServiceWorkerError::take.

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.h:282: void
ReportRegistrationFailure(ServiceWorkerStatusCode status,
Maybe this should just be renamed something like ReportError? All it does is
call OnReportException.

[horo, 2015-03-26 06:10:28]

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:776:
OnReportException(base::UTF8ToUTF16(message + ". " + status_message), -1, -1,
On 2015/03/26 03:56:29, falken wrote:
> The status_message is supposed to be the message to show the user, and we only
> fall back to the generic message if it doesn't exist: see
> GetServiceWorkerRegistrationStatusResponse and ServiceWorkerError::take.

Done.

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/1030103003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.h:282: void
ReportRegistrationFailure(ServiceWorkerStatusCode status,
On 2015/03/26 03:56:29, falken wrote:
> Maybe this should just be renamed something like ReportError? All it does is
> call OnReportException.

Done.

[falken, 2015-03-26 06:15:35]

lgtm

[dgozman, 2015-03-26 10:32:11]

lgtm

[horo, 2015-03-26 10:38:12]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2015-03-26 10:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030103003/40001

[commit-bot: I haz the power, 2015-03-26 11:22:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-26 11:23:23]

Patchset 2 (id:??) landed as
https://crrev.com/62b1a31dea0cc9372a4b3dbcdec869929af88cce
Cr-Commit-Position: refs/heads/master@{#322354}