content/browser/service_worker/service_worker_register_job.cc - Issue 1030103003: Report error messages to DevTools window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 1030103003: Report error messages to DevTools window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated falken's comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index d765c3c51354059b066b9583c13ce3912c2dfa1f..4f6620aecc88af04b43d6bddf4b4931c962104d6 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -458,6 +458,8 @@ void ServiceWorkerRegisterJob::CompleteInternal(

if (should_uninstall_on_failure_)

registration()->ClearWhenReady();

if (new_version()) {

+ if (status != SERVICE_WORKER_ERROR_EXISTS)

+ new_version()->ReportError(status, status_message);

registration()->UnsetVersion(new_version());

new_version()->Doom();

}