Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1030103002: Transitions: Downgrade transition to animation after it has finished (Closed)

Created:
5 years, 9 months ago by samli
Modified:
5 years, 9 months ago
Reviewers:
dstockwell
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Transitions: Downgrade transition to animation after it has finished When a transition finishes, it needs to be downgraded to a normal animation to avoid retriggering another transition when it is replayed via the Web Animations API. This occurred in cancel(), but cancel() is no longer always called when a transition is finished. This change ensures that transitions are downgraded regardless of how it was finished. BUG=464247 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
A LayoutTests/web-animations-api/transitions-replay.html View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
samli
5 years, 9 months ago (2015-03-25 03:07:22 UTC) #2
dstockwell
lgtm
5 years, 9 months ago (2015-03-25 03:19:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030103002/1
5 years, 9 months ago (2015-03-25 04:03:42 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 06:28:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192500

Powered by Google App Engine
This is Rietveld 408576698