Reset is_completed_ before attempting a new crx component download.

Reset is_completed_ before attempting a new crx component download.

When downloading a url, the state of the BackgroundDownloader must be
reset.

A better solution later on would be implementing a BitsFetcher that can
only do one download, similar to UrlFetcher. This avoids the situation
when dirty state post-download is carried over to a subsequent
download.

BUG=304354
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242108

[Sorin Jianu, 2013-12-19 23:03:55]

I've found a bug when attempting to download from multiple urls. After
completing and failing the first url, the state of  the downloader was
"completed", which prevented the second, fallback url, to be downloaded.

[waffles, 2013-12-19 23:21:24]

lgtm; single comment is not impactful

https://codereview.chromium.org/102993014/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/background_downloader_win.cc (right):

https://codereview.chromium.org/102993014/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/background_downloader_win.cc:408:
download_start_time_ = base::Time::Now();
Should we initialize these when we initialize is_completed_?

I know that OnDownloading gets called on the FILE thread, so there isn't a race
here, but it still seems non-optimal.

[Sorin Jianu, 2013-12-19 23:30:04]

https://codereview.chromium.org/102993014/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/background_downloader_win.cc (right):

https://codereview.chromium.org/102993014/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/background_downloader_win.cc:408:
download_start_time_ = base::Time::Now();
On 2013/12/19 23:21:24, waffles wrote:
> Should we initialize these when we initialize is_completed_?
> 
> I know that OnDownloading gets called on the FILE thread, so there isn't a
race
> here, but it still seems non-optimal.

Done.

[commit-bot: I haz the power, 2013-12-19 23:33:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/102993014/20001

[cpu_(ooo_6.6-7.5), 2013-12-20 00:06:46]

lgtm

[commit-bot: I haz the power, 2013-12-20 02:58:38]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-20 03:03:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/102993014/20001

[commit-bot: I haz the power, 2013-12-20 10:40:11]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 14:55:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/102993014/20001

[commit-bot: I haz the power, 2013-12-20 17:02:23]

Change committed as 242108