Reset is_completed_ before attempting a new crx component download.

chrome/browser/component_updater/background_downloader_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/background_downloader_win.h"
 
 #include <atlbase.h>
 #include <atlcom.h>
 
 #include <functional>
@@ skipping 371 matching lines @@
                    url));
 }
 
 // Called once when this class is asked to do a download. Creates or opens
 // an existing bits job, hooks up the notifications, and starts the timer.
 void BackgroundDownloader::BeginDownload(const GURL& url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   DCHECK(!timer_);
 
+  is_completed_ = false;
+
   HRESULT hr = QueueBitsJob(url);
   if (FAILED(hr)) {
     EndDownload(hr);
     return;
   }
 
   // A repeating timer retains the user task. This timer can be stopped and
   // reset multiple times.
   timer_.reset(new base::RepeatingTimer<BackgroundDownloader>);
   timer_->Start(FROM_HERE,
                 base::TimeDelta::FromSeconds(kJobPollingIntervalSec),
                 this,
                 &BackgroundDownloader::OnDownloading);
 
   download_start_time_ = base::Time::Now();

[waffles, 2013/12/19 23:21:24]

Should we initialize these when we initialize is_completed_?

I know that OnDownloading gets called on the FILE thread, so there isn't a race
here, but it still seems non-optimal.

[Sorin Jianu, 2013/12/19 23:30:04]

Done.

   job_stuck_begin_time_ = download_start_time_;
 }
 
 // Called any time the timer fires.
 void BackgroundDownloader::OnDownloading() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   DCHECK(job_);
 
   DCHECK(!is_completed_);
@@ skipping 276 matching lines @@
 }
 
 bool BackgroundDownloader::IsStuck() {
   const base::TimeDelta job_stuck_timeout(
       base::TimeDelta::FromMinutes(kJobStuckTimeoutMin));
   return job_stuck_begin_time_ + job_stuck_timeout < base::Time::Now();
 }
 
 }  // namespace component_updater