Issue 1029893007: Disable flaky ShellApiTest.Basic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1029893007: Disable flaky ShellApiTest.Basic. (Closed)

Created:
5 years, 9 months ago by dgozman

Modified:
5 years, 9 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@move-to-frame

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable flaky ShellApiTest.Basic. BUG=470873 TBR=yoz@chromium.org NOTRY=true Committed: https://crrev.com/12433c0cdc2cc004e662203a9519c7d8ba500afe Cr-Commit-Position: refs/heads/master@{#322385}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	extensions/shell/browser/shell_browsertest.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029893007/1

5 years, 9 months ago (2015-03-26 15:14:04 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/12433c0cdc2cc004e662203a9519c7d8ba500afe Cr-Commit-Position: refs/heads/master@{#322385}

5 years, 9 months ago (2015-03-26 15:15:19 UTC) #5

rmcilroy

5 years, 8 months ago (2015-04-13 12:57:53 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1088513002/ by rmcilroy@chromium.org.

The reason for reverting is: The underlying issue should now be fixed.

BUG=470133,470873.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages