extensions/shell/browser/shell_browsertest.cc - Issue 1029893007: Disable flaky ShellApiTest.Basic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_browsertest.cc

Issue 1029893007: Disable flaky ShellApiTest.Basic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-to-frame

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/shell_browsertest.cc

diff --git a/extensions/shell/browser/shell_browsertest.cc b/extensions/shell/browser/shell_browsertest.cc

index baf75d9f712243084a201aa9655871c52a371e12..93e6b39d5f84b941e83d51266a4b2785f7538a37 100644

--- a/extensions/shell/browser/shell_browsertest.cc

+++ b/extensions/shell/browser/shell_browsertest.cc

@@ -17,8 +17,14 @@

namespace extensions {

+// Flaky on linux. See http://crbug.com/470873.

+#if defined(OS_LINUX)

+#define MAYBE_Basic DISABLED_Basic

+#else

+#define MAYBE_Basic Basic

+#endif

// Test that we can open an app window and wait for it to load.

-IN_PROC_BROWSER_TEST_F(ShellApiTest, Basic) {

+IN_PROC_BROWSER_TEST_F(ShellApiTest, MAYBE_Basic) {

ASSERT_TRUE(RunAppTest("platform_app")) << message_;

// A window was created.

« no previous file with comments | « no previous file | no next file » | no next file with comments »