Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1029893002: OOPIF: Create subframe FrameNavigationEntries for AUTO_SUBFRAME navigations. (Closed)

Created:
5 years, 9 months ago by Charlie Reis
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOPIF: Create subframe FrameNavigationEntries for AUTO_SUBFRAME navigations. Only takes effect in --site-per-process mode. Just the first phase of adding frame entries; won't handle nested iframes or history navigations yet. BUG=236848 TEST=New unit and browser tests pass in --site-per-process mode. Committed: https://crrev.com/625a0c7daf175770733234a1ba3a2ebb70e4c107 Cr-Commit-Position: refs/heads/master@{#322088}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -16 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 3 chunks +54 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 2 chunks +86 lines, -16 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 3 chunks +22 lines, -0 lines 1 comment Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Ok, time to start filling in the tree of FrameNavigationEntries! I decided to start small ...
5 years, 9 months ago (2015-03-24 18:05:13 UTC) #2
Avi (use Gerrit)
This LGTM. You're sneaking in a few new tests for me to pass in my ...
5 years, 9 months ago (2015-03-24 21:02:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029893002/1
5 years, 9 months ago (2015-03-24 21:39:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 23:17:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 23:18:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/625a0c7daf175770733234a1ba3a2ebb70e4c107
Cr-Commit-Position: refs/heads/master@{#322088}

Powered by Google App Engine
This is Rietveld 408576698