Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1029893002: OOPIF: Create subframe FrameNavigationEntries for AUTO_SUBFRAME navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 0b0f411a1a041f52893e84357af935f7fe81c0df..70dcfd97fe8a138fa0d2ea2d5f44945c01998e7d 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1294,6 +1294,18 @@ bool NavigationControllerImpl::RendererDidNavigateAutoSubframe(
return true;
}
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kSitePerProcess)) {
+ // This may be a "new auto" case where we add a new FrameNavigationEntry, or
+ // it may be a "history auto" case where we update an existing one.
+ int64 frame_tree_node_id = rfh->frame_tree_node()->frame_tree_node_id();
+ NavigationEntryImpl* last_committed = GetLastCommittedEntry();
+ last_committed->AddOrUpdateFrameEntry(frame_tree_node_id,
+ rfh->GetSiteInstance(),
+ params.url,
+ params.referrer);
+ }
+
// We do not need to discard the pending entry in this case, since we will
// not generate commit notifications for this auto-subframe navigation.
return false;

Powered by Google App Engine
This is Rietveld 408576698