Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102973005: Move URLBlacklistManager to components/policy. (Closed)

Created:
7 years ago by Joao da Silva
Modified:
7 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Move URLBlacklistManager to components/policy. This enables building that class on the iOS build. BUG=271392 TBR=joaodasilva@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241421

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase, fixed linkage of policy_component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -624 lines) Patch
M chrome/browser/managed_mode/managed_mode_url_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/url_blacklist_manager.h View 1 2 3 4 5 1 chunk +0 lines, -226 lines 0 comments Download
D chrome/browser/policy/url_blacklist_manager.cc View 1 2 3 4 5 1 chunk +0 lines, -383 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M components/policy.gypi View 1 2 3 4 5 6 3 chunks +6 lines, -0 lines 0 comments Download
M components/policy/core/DEPS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + components/policy/core/common/url_blacklist_manager.h View 1 2 3 4 5 5 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/common/url_blacklist_manager.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
This is the move after https://codereview.chromium.org/110643005. PTAL, thanks!
7 years ago (2013-12-12 15:57:38 UTC) #1
Joao da Silva
Julian, can you have a look? (Bartosz OOO)
7 years ago (2013-12-13 14:40:57 UTC) #2
pastarmovj
lgtm
7 years ago (2013-12-16 13:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/102973005/70001
7 years ago (2013-12-17 10:27:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/102973005/80001
7 years ago (2013-12-17 16:29:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=101911
7 years ago (2013-12-17 17:01:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/102973005/100001
7 years ago (2013-12-17 21:17:48 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-17 23:58:56 UTC) #8
Message was sent while issue was closed. 
Change committed as 241421

Powered by Google App Engine
This is Rietveld 408576698