Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chromeos/dbus/fake_shill_manager_client.cc

Issue 1029563002: Fix the fake portaled WiFi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/fake_shill_manager_client.cc
diff --git a/chromeos/dbus/fake_shill_manager_client.cc b/chromeos/dbus/fake_shill_manager_client.cc
index 2702ad988bc9002e20f70d5f653ec323a215225f..0f76b94acd01d7f672414df181f8e800cc1c087f 100644
--- a/chromeos/dbus/fake_shill_manager_client.cc
+++ b/chromeos/dbus/fake_shill_manager_client.cc
@@ -721,18 +721,15 @@ void FakeShillManagerClient::SetupDefaultEnvironment() {
if (portaled) {
const std::string kPortaledWifiPath = "/service/portaled_wifi";
- services->AddService(kPortaledWifiPath,
- "portaled_wifi_guid",
- "Portaled Wifi" /* name */,
- shill::kTypeWifi,
- shill::kStatePortal,
- add_to_visible);
+ services->AddService(kPortaledWifiPath, "portaled_wifi_guid",
+ "Portaled Wifi" /* name */, shill::kTypeWifi,
+ shill::kStateIdle, add_to_visible);
services->SetServiceProperty(kPortaledWifiPath,
shill::kSecurityClassProperty,
base::StringValue(shill::kSecurityNone));
- services->SetConnectBehavior(kPortaledWifiPath,
- base::Bind(&UpdatePortaledWifiState,
- "portaled_wifi"));
+ services->SetConnectBehavior(
+ kPortaledWifiPath,
+ base::Bind(&UpdatePortaledWifiState, "/service/portaled_wifi"));
stevenjb 2015/03/23 16:10:01 nit: Use a const to avoid this mistake in the futu
pneubeck (no reviews) 2015/03/24 08:39:13 yes, of course.
services->SetServiceProperty(kPortaledWifiPath,
shill::kConnectableProperty,
base::FundamentalValue(true));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698