Fix the fake portaled WiFi.

chromeos/dbus/fake_shill_manager_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/fake_shill_manager_client.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 703 matching lines @@
                          "",  /* empty GUID */
                          "wifi3" /* name */,
                          shill::kTypeWifi,
                          shill::kStateIdle,
                          add_to_visible);
     services->SetServiceProperty(
         kWifi3Path, shill::kSignalStrengthProperty, base::FundamentalValue(40));
 
     if (portaled) {
       const std::string kPortaledWifiPath = "/service/portaled_wifi";
-      services->AddService(kPortaledWifiPath,
-                           "portaled_wifi_guid",
-                           "Portaled Wifi" /* name */,
-                           shill::kTypeWifi,
-                           shill::kStatePortal,
-                           add_to_visible);
+      services->AddService(kPortaledWifiPath, "portaled_wifi_guid",
+                           "Portaled Wifi" /* name */, shill::kTypeWifi,
+                           shill::kStateIdle, add_to_visible);
       services->SetServiceProperty(kPortaledWifiPath,
                                    shill::kSecurityClassProperty,
                                    base::StringValue(shill::kSecurityNone));
-      services->SetConnectBehavior(kPortaledWifiPath,
-                                   base::Bind(&UpdatePortaledWifiState,
-                                              "portaled_wifi"));
+      services->SetConnectBehavior(
+          kPortaledWifiPath,
+          base::Bind(&UpdatePortaledWifiState, "/service/portaled_wifi"));

[stevenjb, 2015/03/23 16:10:01]

nit: Use a const to avoid this mistake in the future?

[pneubeck (no reviews), 2015/03/24 08:39:13]

yes, of course.

       services->SetServiceProperty(kPortaledWifiPath,
                                    shill::kConnectableProperty,
                                    base::FundamentalValue(true));
       profiles->AddService(shared_profile, kPortaledWifiPath);
     }
   }
 
   // Wimax
   const std::string kWimaxPath = "/service/wimax1";
   state = GetInitialStateForType(shill::kTypeWimax, &enabled);
@@ skipping 415 matching lines @@
   *enabled = true;
   if ((state == shill::kStatePortal && type != shill::kTypeWifi) ||
       (state == kNetworkActivated && type != shill::kTypeCellular)) {
     LOG(WARNING) << "Invalid state: " << state << " for " << type;
     return shill::kStateIdle;
   }
   return state;
 }
 
 }  // namespace chromeos