Fix the fake portaled WiFi.

Fix the fake portaled WiFi.

The service path argument to set the 'connect behavior' was wrong.
Now, one can again pass the command line argument
 --shill-stub="wifi=portal"
and then connect to the WiFi "Portaled Wifi", which will correctly trigger the captive portal notification.

Committed: https://crrev.com/4de9f91afa9e2ce7150a2dbe5ba0c5d4dadfd01f
Cr-Commit-Position: refs/heads/master@{#321959}

[pneubeck (no reviews), 2015-03-23 11:07:50]

pneubeck@chromium.org changed reviewers:
+ stevenjb@chromium.org

[pneubeck (no reviews), 2015-03-23 11:07:50]

ptal

[stevenjb, 2015-03-23 16:10:01]

lgtm

https://codereview.chromium.org/1029563002/diff/1/chromeos/dbus/fake_shill_ma...
File chromeos/dbus/fake_shill_manager_client.cc (right):

https://codereview.chromium.org/1029563002/diff/1/chromeos/dbus/fake_shill_ma...
chromeos/dbus/fake_shill_manager_client.cc:732:
base::Bind(&UpdatePortaledWifiState, "/service/portaled_wifi"));
nit: Use a const to avoid this mistake in the future?

[pneubeck (no reviews), 2015-03-24 08:39:13]

https://codereview.chromium.org/1029563002/diff/1/chromeos/dbus/fake_shill_ma...
File chromeos/dbus/fake_shill_manager_client.cc (right):

https://codereview.chromium.org/1029563002/diff/1/chromeos/dbus/fake_shill_ma...
chromeos/dbus/fake_shill_manager_client.cc:732:
base::Bind(&UpdatePortaledWifiState, "/service/portaled_wifi"));
On 2015/03/23 16:10:01, stevenjb wrote:
> nit: Use a const to avoid this mistake in the future?

yes, of course.

[pneubeck (no reviews), 2015-03-24 08:39:17]

The CQ bit was checked by pneubeck@chromium.org

[pneubeck (no reviews), 2015-03-24 08:39:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1029563002/#ps20001
(title: "Use the path constant.")

[commit-bot: I haz the power, 2015-03-24 08:39:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029563002/20001

[commit-bot: I haz the power, 2015-03-24 09:12:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-24 09:13:51]

Patchset 2 (id:??) landed as
https://crrev.com/4de9f91afa9e2ce7150a2dbe5ba0c5d4dadfd01f
Cr-Commit-Position: refs/heads/master@{#321959}