Issue 102943003: Use PushReturnAddressFrom and PopReturnAddressTo to manipulate return address for X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102943003: Use PushReturnAddressFrom and PopReturnAddressTo to manipulate return address for X64 (Closed)

Created:
7 years ago by haitao.feng

Modified:
6 years, 11 months ago

Reviewers:
dcarney, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use PushReturnAddressFrom and PopReturnAddressTo to manipulate return address for X64 R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18477

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	src/x64/stub-cache-x64.cc	View		3 chunks	+3 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

https://codereview.chromium.org/102943003/diff/1/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): https://codereview.chromium.org/102943003/diff/1/src/x64/stub-cache-x64.cc#newcode478 src/x64/stub-cache-x64.cc:478: __ lea(rax, args.GetArgumentOperand(offset - FCA::kHolderIndex)); Sorry this one was ...

7 years ago (2013-12-04 08:04:26 UTC) #2

haitao.feng

6 years, 11 months ago (2014-01-08 04:32:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r18477 (presubmit successful).

Expand Messages | Collapse Messages