Issue 25682002: Use StackArgumentsAccessor for PropertyCallback and FunctionCallback for X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25682002: Use StackArgumentsAccessor for PropertyCallback and FunctionCallback for X64 (Closed)

Created:
7 years, 2 months ago by haitao.feng

Modified:
7 years, 2 months ago

Reviewers:
dcarney, Michael Starzinger, danno, marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use StackArgumentsAccessor for PropertyCallback and FunctionCallback for X64 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17093

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -21 lines)			Patch
	M	src/x64/stub-cache-x64.cc	View		6 chunks	+31 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

PTAL. This is submitted as planned. The X32 port rebase commit is at https://github.com/fenghaitao/v8/commit/da4ab3ef2d15e4cf993d8e8b4b7560a112903fbf. Once ...

7 years, 2 months ago (2013-10-02 06:08:35 UTC) #1

haitao.feng

Thanks for the review. I will commit it when the tree is open again.

7 years, 2 months ago (2013-10-02 12:02:08 UTC) #3

haitao.feng

7 years, 2 months ago (2013-10-03 00:33:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r17093 (presubmit successful).

Expand Messages | Collapse Messages