Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 1029413002: PPC: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
MTBrandyberry
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily Port 6689cc27ebe60685c025de9ae1f09919093f8213 Original commit message: Handlers should be in charge of this work. The change uncovered a bug in vector-ics related to keyed loads into strings. It's important for StringCharCodeAtGenerator, a helper used in full code and in LoadIndexedStringStub (a handler) to protect the vector and slot registers when it makes a runtime call to convert a HeapNumber to a Smi. It's still possible for the handler to MISS after this call, perhaps due to out of bounds access. In that case, the vector and slot registers need to be delivered safely to the MISS handler. R=mbrandy@us.ibm.com, svenpanne@chromium.org BUG= Committed: https://crrev.com/039247c4f347ab80a1f4cd5dab0cf7877eb08625 Cr-Commit-Position: refs/heads/master@{#27430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M src/ppc/code-stubs-ppc.cc View 6 chunks +17 lines, -8 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
Latest PPC port. Seven,could you add your approval to this one and the previous one, ...
5 years, 9 months ago (2015-03-24 16:47:48 UTC) #1
MTBrandyberry
On 2015/03/24 16:47:48, michael_dawson wrote: > Latest PPC port. > > Seven,could you add your ...
5 years, 9 months ago (2015-03-24 16:58:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029413002/1
5 years, 9 months ago (2015-03-25 01:51:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 06:42:22 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 06:42:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/039247c4f347ab80a1f4cd5dab0cf7877eb08625
Cr-Commit-Position: refs/heads/master@{#27430}

Powered by Google App Engine
This is Rietveld 408576698