Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: src/ppc/full-codegen-ppc.cc

Issue 1029413002: PPC: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ppc/code-stubs-ppc.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 4087 matching lines...) Expand 10 before | Expand all | Expand 10 after
4098 __ LoadRoot(result, Heap::kNanValueRootIndex); 4098 __ LoadRoot(result, Heap::kNanValueRootIndex);
4099 __ b(&done); 4099 __ b(&done);
4100 4100
4101 __ bind(&need_conversion); 4101 __ bind(&need_conversion);
4102 // Load the undefined value into the result register, which will 4102 // Load the undefined value into the result register, which will
4103 // trigger conversion. 4103 // trigger conversion.
4104 __ LoadRoot(result, Heap::kUndefinedValueRootIndex); 4104 __ LoadRoot(result, Heap::kUndefinedValueRootIndex);
4105 __ b(&done); 4105 __ b(&done);
4106 4106
4107 NopRuntimeCallHelper call_helper; 4107 NopRuntimeCallHelper call_helper;
4108 generator.GenerateSlow(masm_, call_helper); 4108 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4109 4109
4110 __ bind(&done); 4110 __ bind(&done);
4111 context()->Plug(result); 4111 context()->Plug(result);
4112 } 4112 }
4113 4113
4114 4114
4115 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4115 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4116 ZoneList<Expression*>* args = expr->arguments(); 4116 ZoneList<Expression*>* args = expr->arguments();
4117 DCHECK(args->length() == 2); 4117 DCHECK(args->length() == 2);
4118 VisitForStackValue(args->at(0)); 4118 VisitForStackValue(args->at(0));
(...skipping 21 matching lines...) Expand all
4140 __ LoadRoot(result, Heap::kempty_stringRootIndex); 4140 __ LoadRoot(result, Heap::kempty_stringRootIndex);
4141 __ b(&done); 4141 __ b(&done);
4142 4142
4143 __ bind(&need_conversion); 4143 __ bind(&need_conversion);
4144 // Move smi zero into the result register, which will trigger 4144 // Move smi zero into the result register, which will trigger
4145 // conversion. 4145 // conversion.
4146 __ LoadSmiLiteral(result, Smi::FromInt(0)); 4146 __ LoadSmiLiteral(result, Smi::FromInt(0));
4147 __ b(&done); 4147 __ b(&done);
4148 4148
4149 NopRuntimeCallHelper call_helper; 4149 NopRuntimeCallHelper call_helper;
4150 generator.GenerateSlow(masm_, call_helper); 4150 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4151 4151
4152 __ bind(&done); 4152 __ bind(&done);
4153 context()->Plug(result); 4153 context()->Plug(result);
4154 } 4154 }
4155 4155
4156 4156
4157 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4157 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4158 ZoneList<Expression*>* args = expr->arguments(); 4158 ZoneList<Expression*>* args = expr->arguments();
4159 DCHECK_EQ(2, args->length()); 4159 DCHECK_EQ(2, args->length());
4160 VisitForStackValue(args->at(0)); 4160 VisitForStackValue(args->at(0));
(...skipping 1293 matching lines...) Expand 10 before | Expand all | Expand 10 after
5454 return ON_STACK_REPLACEMENT; 5454 return ON_STACK_REPLACEMENT;
5455 } 5455 }
5456 5456
5457 DCHECK(interrupt_address == 5457 DCHECK(interrupt_address ==
5458 isolate->builtins()->OsrAfterStackCheck()->entry()); 5458 isolate->builtins()->OsrAfterStackCheck()->entry());
5459 return OSR_AFTER_STACK_CHECK; 5459 return OSR_AFTER_STACK_CHECK;
5460 } 5460 }
5461 } 5461 }
5462 } // namespace v8::internal 5462 } // namespace v8::internal
5463 #endif // V8_TARGET_ARCH_PPC 5463 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/ppc/code-stubs-ppc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698