Don't call PaintChildren() from inside OnPaint().

Don't call PaintChildren() from inside OnPaint().

OnPaint() is not part of the recursion, it won't have access to the
necessary pieces to do recursion.

If you need to do painting while inside the recursion, this should
happen in PaintChildren(). So move the contents of OnPaint() to
PaintChildren().

R=estade@chromium.org
BUG=466426
Committed: https://crrev.com/d2c0e1b3b0c1a34652246603b672298f73261ed4
Cr-Commit-Position: refs/heads/master@{#322487}

[danakj, 2015-03-25 23:12:42]

danakj@chromium.org changed reviewers:
+ estade@chromium.org
- sky@chromium.org

[danakj, 2015-03-26 00:44:10]

Hi Evan,

How do I verify that I'm not breaking something when touching the paint code
here? I've tried and failed at trying to manually see this code get hit.

[Evan Stade, 2015-03-26 01:54:50]

On 2015/03/26 00:44:10, danakj wrote:
> Hi Evan,
> 
> How do I verify that I'm not breaking something when touching the paint code
> here? I've tried and failed at trying to manually see this code get hit.

https://995d1d846ff2ec4fd846220368e80c16471c764d.googledrive.com/host/0B28Bnx...

the notification area is the stuff at the top (Save and protect your details
with Google Wallet)
the suggested button is the button with the down arrow to the right of a details
section
the overlay is visible when you use wallet and click "continue". You should see
something like "generating google wallet virtual card..."

[danakj, 2015-03-26 22:26:27]

Patchset #2 (id:20001) has been deleted

[danakj, 2015-03-26 22:26:34]

On 2015/03/26 01:54:50, Evan Stade wrote:
> On 2015/03/26 00:44:10, danakj wrote:
> > Hi Evan,
> > 
> > How do I verify that I'm not breaking something when touching the paint code
> > here? I've tried and failed at trying to manually see this code get hit.
> 
>
https://995d1d846ff2ec4fd846220368e80c16471c764d.googledrive.com/host/0B28Bnx...
> 
> the notification area is the stuff at the top (Save and protect your details
> with Google Wallet)
> the suggested button is the button with the down arrow to the right of a
details
> section
> the overlay is visible when you use wallet and click "continue". You should
see
> something like "generating google wallet virtual card..."

Hooray, thanks. I can verify that this does not change the visual appearance of
the dialog. I signed in with wallet and got an error notification to appear to
verify.

PTAL

[Evan Stade, 2015-03-26 22:40:11]

did you also check the continue case (generating wallet card)? if so lgtm

[danakj, 2015-03-26 22:49:36]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-26 22:49:53]

On Thu, Mar 26, 2015 at 3:40 PM, <estade@chromium.org> wrote:

> did you also check the continue case (generating wallet card)? if so lgtm
>

I think so. I hit continue, that's how I got the wallet notification error
(yellow bar with a little up arrow).

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-03-26 22:50:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029263011/1

[commit-bot: I haz the power, 2015-03-26 22:54:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-26 22:54:59]

Patchset 1 (id:??) landed as
https://crrev.com/d2c0e1b3b0c1a34652246603b672298f73261ed4
Cr-Commit-Position: refs/heads/master@{#322487}

[Evan Stade, 2015-03-26 22:58:07]

On 2015/03/26 22:54:59, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d2c0e1b3b0c1a34652246603b672298f73261ed4
> Cr-Commit-Position: refs/heads/master@{#322487}

this is the screen you need to verify:
https://screenshot.googleplex.com/s4WhPoJ0W4.png

[danakj, 2015-03-26 23:03:13]

On Thu, Mar 26, 2015 at 3:58 PM, <estade@chromium.org> wrote:

> On 2015/03/26 22:54:59, I haz the power (commit-bot) wrote:
>
>> Patchset 1 (id:??) landed as
>> https://crrev.com/d2c0e1b3b0c1a34652246603b672298f73261ed4
>> Cr-Commit-Position: refs/heads/master@{#322487}
>>
>
> this is the screen you need to verify:
> https://screenshot.googleplex.com/s4WhPoJ0W4.png


Oh, I'm not sure how to get there.

I assume this isn't by putting in a credit card number and hitting continue?

I tried hitting the "Use google wallet" and logged in, and it gave me
instead "You must upgrade Chromium to use Google Wallet [$1]" and back to
the fill in credit card screen.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Evan Stade, 2015-03-27 18:52:45]

On 2015/03/26 23:03:13, danakj wrote:
> On Thu, Mar 26, 2015 at 3:58 PM, <mailto:estade@chromium.org> wrote:
> 
> > On 2015/03/26 22:54:59, I haz the power (commit-bot) wrote:
> >
> >> Patchset 1 (id:??) landed as
> >> https://crrev.com/d2c0e1b3b0c1a34652246603b672298f73261ed4
> >> Cr-Commit-Position: refs/heads/master@{#322487}
> >>
> >
> > this is the screen you need to verify:
> > https://screenshot.googleplex.com/s4WhPoJ0W4.png
> 
> 
> Oh, I'm not sure how to get there.
> 
> I assume this isn't by putting in a credit card number and hitting continue?
> 
> I tried hitting the "Use google wallet" and logged in, and it gave me
> instead "You must upgrade Chromium to use Google Wallet [$1]" and back to
> the fill in credit card screen.
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

yea.. might be a problem of your api key. Do you have a 'google_api_key' set up
in ~/.gyp/include.gypi?

[danakj, 2015-03-27 18:55:52]

On Fri, Mar 27, 2015 at 11:52 AM, <estade@chromium.org> wrote:

> On 2015/03/26 23:03:13, danakj wrote:
>
>  On Thu, Mar 26, 2015 at 3:58 PM, <mailto:estade@chromium.org> wrote:
>>
>
>  > On 2015/03/26 22:54:59, I haz the power (commit-bot) wrote:
>> >
>> >> Patchset 1 (id:??) landed as
>> >> https://crrev.com/d2c0e1b3b0c1a34652246603b672298f73261ed4
>> >> Cr-Commit-Position: refs/heads/master@{#322487}
>> >>
>> >
>> > this is the screen you need to verify:
>> > https://screenshot.googleplex.com/s4WhPoJ0W4.png
>>
>
>
>  Oh, I'm not sure how to get there.
>>
>
>  I assume this isn't by putting in a credit card number and hitting
>> continue?
>>
>
>  I tried hitting the "Use google wallet" and logged in, and it gave me
>> instead "You must upgrade Chromium to use Google Wallet [$1]" and back to
>> the fill in credit card screen.
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> yea.. might be a problem of your api key. Do you have a 'google_api_key'
> set up
> in ~/.gyp/include.gypi?
>

I have them set via environment vars.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.