Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2892)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 1029263011: Don't call PaintChildren() from inside OnPaint(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index d1b4f6701de5dfe5dad5219dbc03a1ff8c2b773f..4bdb7afb128bc232d10dc9a0da3e5eeacc55029b 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -685,8 +685,6 @@ void AutofillDialogViews::OverlayView::OnPaint(gfx::Canvas* canvas) {
paint.setStyle(SkPaint::kStroke_Style);
canvas->DrawPath(arrow, paint);
}
-
- PaintChildren(canvas, views::CullSet());
}
void AutofillDialogViews::OverlayView::OnNativeThemeChanged(
@@ -763,12 +761,7 @@ const char* AutofillDialogViews::NotificationArea::GetClassName() const {
void AutofillDialogViews::NotificationArea::PaintChildren(
gfx::Canvas* canvas,
const views::CullSet& cull_set) {
-}
-
-void AutofillDialogViews::NotificationArea::OnPaint(gfx::Canvas* canvas) {
- views::View::OnPaint(canvas);
views::View::PaintChildren(canvas, views::CullSet());
-
if (HasArrow()) {
DrawArrow(
canvas,
@@ -1002,11 +995,6 @@ const char* AutofillDialogViews::SuggestedButton::GetClassName() const {
return kSuggestedButtonClassName;
}
-void AutofillDialogViews::SuggestedButton::PaintChildren(
- gfx::Canvas* canvas,
- const views::CullSet& cull_set) {
-}
-
void AutofillDialogViews::SuggestedButton::OnPaint(gfx::Canvas* canvas) {
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
const gfx::Insets insets = GetInsets();
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698