Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1029263003: [telemetry] Sort imports in Telemetry and its dependents. (Closed)

Created:
5 years, 9 months ago by dtu
Modified:
5 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, devtools-reviews_chromium.org, jam, yurys, darin-cc_chromium.org, telemetry-reviews_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Sort imports in Telemetry and its dependents. As part of the Telemetry public API refactor, I wrote a tool that sorts imports. The tool will be checked in separately, but here's all the import changes in Telemetry and its dependencies. It'll be easier to test the refactor tool if we do the import sorting in advance, so it doesn't clutter the diffs for the module moves. Style guide rule: "Within each grouping, imports should be sorted lexicographically, ignoring case, according to each module's full package path." BUG=449308 TEST=trybots (tools/telemetry/run_tests; tools/perf/run_tests) Committed: https://crrev.com/fa7987281c5932b682dd8d8ed031d827c0c0ef61 Cr-Commit-Position: refs/heads/master@{#322211}

Patch Set 1 #

Patch Set 2 : Manual adjustments in tools/perf #

Total comments: 1

Patch Set 3 : aiolos #

Patch Set 4 : Ensure we're up to date. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -378 lines) Patch
M chrome/test/telemetry/chromeos/login_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/memory_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/trace_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/integration_tests/network_metrics_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/benchmark_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/gpu_times.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/inbox_benchmark.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 1 chunk +5 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M tools/perf/benchmarks/media.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/memory.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/octane.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/oilpan_gc_times.py View 1 1 chunk +5 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/page_cycler.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/polymer_load.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/power.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/repaint.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/scheduler.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/benchmarks/service_worker.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/session_restore.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/skpicture_printer.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/smoothness.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/spaceport.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/speedometer.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/start_with_url.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/startup.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/task_execution_time.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/thread_times.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/v8.py View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/webrtc.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/image_decoding.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/measurement_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/media.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/memory.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/memory_multi_tab.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/page_cycler.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tools/perf/measurements/page_cycler_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/power.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/record_per_area.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/record_per_area_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/repaint.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/session_restore.py View 1 1 chunk +5 lines, -3 lines 0 comments Download
M tools/perf/measurements/skpicture_printer_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/smooth_gesture_util_unittest.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/smoothness.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 1 1 chunk +6 lines, -5 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 1 chunk +5 lines, -3 lines 0 comments Download
M tools/perf/measurements/startup.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/tab_switching.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/task_execution_time_unittest.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/thread_times.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 1 chunk +6 lines, -5 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/v8_detached_context_age_in_gc.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/v8_gc_times_unittest.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/measurements/webrtc.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/cpu.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/keychain_metric.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/loading.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/metrics/media.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/memory.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/power.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/speedindex.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/speedindex_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/startup_metric.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/metrics/system_memory.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/timeline.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/metrics/timeline_unittest.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tools/perf/metrics/webrtc_stats.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/metrics/webrtc_stats_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/alexa1-10000.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/maps.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/pica.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/page_sets/top_desktop_sites_2012Q3.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/topeka.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases/second_batch_js_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_webgl_cases.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/profile_creators/history_profile_extender.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/history_profile_extender_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/examples/measure_trace.py View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/benchmark.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/benchmark_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/_bitmap.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/android_app_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/android_process.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/android_app_backend.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/browser_backend.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +7 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_with_oobe.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/extension_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/system_info_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/tracing_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/tracing_backend_unittest.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/codepen_credentials_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_finder.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_unittest.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/discover.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/forwarders/cros_forwarder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/memory_cache_http_server.py View 2 chunks +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_device.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_interface_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_based_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/network_controller_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_screen_recorder_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/iprofiler_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/profiler_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/sample_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/trace_profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/tracing_controller_backend.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/tracing_controller_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/video_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/image_processing/screen_finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/loop_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/play_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/seek_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/buildbot_output_formatter.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/user_story_run_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/inspector_importer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/model.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/tab_id_importer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_chromeos_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/user_story/android/shared_app_state.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/util/cloud_storage.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/util/file_handle_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/failure_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/histogram_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/skip_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/string_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/trace.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/trace_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_components/dev_server.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/layout_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_frame.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_frame_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
dtu
5 years, 9 months ago (2015-03-24 00:23:17 UTC) #2
aiolos (Not reviewing)
https://codereview.chromium.org/1029263003/diff/20001/tools/telemetry/examples/measure_trace.py File tools/telemetry/examples/measure_trace.py (left): https://codereview.chromium.org/1029263003/diff/20001/tools/telemetry/examples/measure_trace.py#oldcode22 tools/telemetry/examples/measure_trace.py:22: # pylint: disable=F0401 Should add a line between the ...
5 years, 9 months ago (2015-03-24 01:22:23 UTC) #3
nednguyen
On 2015/03/24 01:22:23, aiolos wrote: > https://codereview.chromium.org/1029263003/diff/20001/tools/telemetry/examples/measure_trace.py > File tools/telemetry/examples/measure_trace.py (left): > > https://codereview.chromium.org/1029263003/diff/20001/tools/telemetry/examples/measure_trace.py#oldcode22 > ...
5 years, 9 months ago (2015-03-24 01:45:24 UTC) #4
dtu
+OWNERS achuith@ for chrome/test/telemetry/ kbr@ for content/test/gpu/ sclittle for tools/chrome_proxy/
5 years, 9 months ago (2015-03-24 17:08:49 UTC) #6
achuithb
On 2015/03/24 17:08:49, dtu wrote: > +OWNERS > achuith@ for chrome/test/telemetry/ > kbr@ for content/test/gpu/ ...
5 years, 9 months ago (2015-03-24 17:11:18 UTC) #7
aiolos (Not reviewing)
lgtm
5 years, 9 months ago (2015-03-24 17:15:01 UTC) #8
sclittle
LGTM!
5 years, 9 months ago (2015-03-24 17:20:21 UTC) #9
Ken Russell (switch to Gerrit)
lgtm
5 years, 9 months ago (2015-03-24 21:32:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029263003/60001
5 years, 9 months ago (2015-03-24 23:38:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/1104)
5 years, 9 months ago (2015-03-25 03:31:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029263003/60001
5 years, 9 months ago (2015-03-25 19:01:07 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-25 19:46:05 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:46:48 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fa7987281c5932b682dd8d8ed031d827c0c0ef61
Cr-Commit-Position: refs/heads/master@{#322211}

Powered by Google App Engine
This is Rietveld 408576698