tools/perf/measurements/v8_detached_context_age_in_gc.py - Issue 1029263003: [telemetry] Sort imports in Telemetry and its dependents.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/v8_detached_context_age_in_gc.py

Issue 1029263003: [telemetry] Sort imports in Telemetry and its dependents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ensure we're up to date. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import json	5 import json

	6

6 from telemetry.page import page_test	7 from telemetry.page import page_test

7 from telemetry.value import histogram	8 from telemetry.value import histogram

8 from telemetry.value import histogram_util	9 from telemetry.value import histogram_util

9 from telemetry.value import scalar	10 from telemetry.value import scalar

10 from telemetry.value import skip	11 from telemetry.value import skip

11	12

12 _NAME = 'V8.DetachedContextAgeInGC'	13 _NAME = 'V8.DetachedContextAgeInGC'

13 _UNITS = 'garbage_collections'	14 _UNITS = 'garbage_collections'

14 _DISPLAY_NAME = 'V8_DetachedContextAgeInGC'	15 _DISPLAY_NAME = 'V8_DetachedContextAgeInGC'

15 _TYPE = histogram_util.RENDERER_HISTOGRAM	16 _TYPE = histogram_util.RENDERER_HISTOGRAM

(...skipping 29 matching lines...) Expand all Loading...
45 for _ in xrange(MAX_AGE):	46 for _ in xrange(MAX_AGE):

46 tab.CollectGarbage()	47 tab.CollectGarbage()

47 value = _GetMaxDetachedContextAge(tab, self._data_start)	48 value = _GetMaxDetachedContextAge(tab, self._data_start)

48 if value is None:	49 if value is None:

49 results.AddValue(skip.SkipValue(	50 results.AddValue(skip.SkipValue(

50 results.current_page, 'No detached contexts'))	51 results.current_page, 'No detached contexts'))

51 else:	52 else:

52 results.AddValue(scalar.ScalarValue(	53 results.AddValue(scalar.ScalarValue(

53 results.current_page, _DISPLAY_NAME, _UNITS, value,	54 results.current_page, _DISPLAY_NAME, _UNITS, value,

54 description=_DESCRIPTION))	55 description=_DESCRIPTION))

OLD	NEW