Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 102923002: Revert 238454 "Hook up GN to the GYP build system." (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 238454 "Hook up GN to the GYP build system." > Hook up GN to the GYP build system. > > This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions > > Move GYP_DEFINES parsing to Python for GN. > > I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN. > > Currently, GN does not produce any files used by the build, these will be added in a second step. > > BUG=321352 > R=bradnelson@google.com > > Review URL: https://codereview.chromium.org/73623005 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -88 lines) Patch
M trunk/src/build/gyp_chromium View 4 chunks +6 lines, -88 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
7 years ago (2013-12-03 21:21:09 UTC) #1
brettw
7 years ago (2013-12-03 21:21:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r238459.

Powered by Google App Engine
This is Rietveld 408576698