Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 73623005: Move GYP_DEFINES parsing to Python for GN (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years ago
Reviewers:
bradnelson, Nico, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Hook up GN to the GYP build system. This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions Move GYP_DEFINES parsing to Python for GN. I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN. Currently, GN does not produce any files used by the build, these will be added in a second step. BUG=321352 R=bradnelson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238454

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : git log #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -6 lines) Patch
M build/gyp_chromium View 1 2 3 4 5 6 4 chunks +88 lines, -6 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
brettw
Note: depends on https://codereview.chromium.org/62803003/ landing first.
7 years, 1 month ago (2013-11-19 00:29:36 UTC) #1
bradn
LGTM Please add a bug number (you've got some bug tracking gn yes?) https://codereview.chromium.org/73623005/diff/20003/build/gyp_chromium File ...
7 years, 1 month ago (2013-11-19 17:45:57 UTC) #2
brettw
Committed patchset #7 manually as r238454 (presubmit successful).
7 years ago (2013-12-03 21:08:14 UTC) #3
Nico
7 years ago (2013-12-03 22:45:15 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/73623005/diff/170001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/73623005/diff/170001/build/gyp_chromium#newco...
build/gyp_chromium:136: if subprocess.check_output(["file",
"/sbin/init"]).find("ELF 64-bit") >= 0:
(I think the usual thing to do is `getconf LONG_BIT`, fwiw)

Powered by Google App Engine
This is Rietveld 408576698