Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1029193002: Support comments and blank lines in SUPPRESSIONS file (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support comments and blank lines in SUPPRESSIONS file The comment character is #. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f8c5de459fee0816a98a691a12ed21b633b98bb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M testing/tools/run_corpus_tests.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, comments and blank lines as we talked about on an earlier CL.
5 years, 9 months ago (2015-03-23 21:00:29 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-23 21:17:36 UTC) #3
Lei Zhang
On 2015/03/23 21:17:36, Lei Zhang wrote: > lgtm SUPPRESIONS -> SUPPRESSIONS
5 years, 9 months ago (2015-03-23 21:19:17 UTC) #4
Tom Sepez
5 years, 9 months ago (2015-03-23 21:24:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8c5de459fee0816a98a691a12ed21b633b98bb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698