testing/tools/run_corpus_tests.py - Issue 1029193002: Support comments and blank lines in SUPPRESSIONS file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/tools/run_corpus_tests.py

Issue 1029193002: Support comments and blank lines in SUPPRESSIONS file (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/tools/run_corpus_tests.py

diff --git a/testing/tools/run_corpus_tests.py b/testing/tools/run_corpus_tests.py

index d56cb1c238232b34b754d872bda5a32b391a4abf..05be76ef3786a1c9ce98024a3c7ef0fae9c497d9 100755

--- a/testing/tools/run_corpus_tests.py

+++ b/testing/tools/run_corpus_tests.py

@@ -87,7 +87,8 @@ def main():

os.makedirs(working_dir)

with open(os.path.join(testing_dir, 'SUPPRESSIONS')) as f:

- suppression_list = [x.strip() for x in f.readlines()]

+ suppression_list = [y for y in [

+ x.split('#')[0].strip() for x in f.readlines()] if y]

# test files are under .../pdfium/testing/corpus.

failures = []

« no previous file with comments | « no previous file | no next file » | no next file with comments »