Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1029113005: Update mojo sdk to rev cb6c5abfadfea0ca73dca466e2894554ac1ae144 (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
CC:
chromium-reviews, je_julie(Not used), qsr+mojo_chromium.org, plundblad+watch_chromium.org, viettrungluu+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, yuzo+watch_chromium.org, Aaron Boodman, dcheng, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev cb6c5abfadfea0ca73dca466e2894554ac1ae144 R=brettw@chromium.org, erg@chromium.org, jamesr@chromium.org TBR=jamesr@chromium.org Committed: https://crrev.com/e912c8f996d898a1232d885988a54010f8ed0105 Cr-Commit-Position: refs/heads/master@{#322083}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -416 lines) Patch
M build/module_args/mojo.gni View 1 1 chunk +3 lines, -0 lines 1 comment Download
M mojo/services/html_viewer/blink_input_events_type_converters.cc View 6 chunks +39 lines, -52 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/binding.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/tests/binding_unittest.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/application.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/bindings.dart View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/dart/core.dart View 2 chunks +1 line, -2 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/internal.dart View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/rules.gni View 2 chunks +4 lines, -42 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/buffer.dart View 5 chunks +8 lines, -27 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/data_pipe.dart View 8 chunks +8 lines, -31 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/event_stream.dart View 5 chunks +19 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/handle.dart View 4 chunks +13 lines, -16 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/handle_watcher.dart View 13 chunks +70 lines, -78 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/message_pipe.dart View 4 chunks +3 lines, -13 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/src/natives.dart View 1 chunk +70 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/proxy.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/stub.dart View 3 chunks +23 lines, -13 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/timer_queue.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/application/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/mojo_services/src/accessibility/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/clipboard/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/content_handler/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/geometry/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/geometry/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/gpu/public/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo_services/src/http_server/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/http_server/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/input_events/public/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo_services/src/input_events/public/interfaces/input_event_constants.mojom View 2 chunks +10 lines, -41 lines 0 comments Download
M third_party/mojo_services/src/input_events/public/interfaces/input_events.mojom View 2 chunks +18 lines, -40 lines 0 comments Download
M third_party/mojo_services/src/native_viewport/public/cpp/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo_services/src/native_viewport/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/navigation/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/surfaces/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/surfaces/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/window_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
sky
brettw=build/module_args/mojo.gni erg=mojo/services/html_viewer/blink_input_events_type_converters.cc jamesr=rest, which is the result of running rev_sdk.py TBRing james for mojo changes ...
5 years, 9 months ago (2015-03-24 19:51:12 UTC) #1
Elliot Glaysher
lgtm
5 years, 9 months ago (2015-03-24 19:54:38 UTC) #2
brettw
.gni lgtm with rename https://codereview.chromium.org/1029113005/diff/20001/build/module_args/mojo.gni File build/module_args/mojo.gni (right): https://codereview.chromium.org/1029113005/diff/20001/build/module_args/mojo.gni#newcode17 build/module_args/mojo.gni:17: network_service_root = "//mojo/services" Can you ...
5 years, 9 months ago (2015-03-24 21:53:07 UTC) #3
sky
On 2015/03/24 21:53:07, brettw wrote: > .gni lgtm with rename > > https://codereview.chromium.org/1029113005/diff/20001/build/module_args/mojo.gni > File ...
5 years, 9 months ago (2015-03-24 21:56:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029113005/20001
5 years, 9 months ago (2015-03-24 21:56:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 22:43:58 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 22:44:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e912c8f996d898a1232d885988a54010f8ed0105
Cr-Commit-Position: refs/heads/master@{#322083}

Powered by Google App Engine
This is Rietveld 408576698