Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/mojo/src/mojo/public/cpp/bindings/binding.h

Issue 1029113005: Update mojo sdk to rev cb6c5abfadfea0ca73dca466e2894554ac1ae144 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/public/cpp/bindings/binding.h
diff --git a/third_party/mojo/src/mojo/public/cpp/bindings/binding.h b/third_party/mojo/src/mojo/public/cpp/bindings/binding.h
index a982bdbd4b10642837f8e1306253f0832f43e95b..05a162e6518dfdecb84092389b27e4fab9ca3302 100644
--- a/third_party/mojo/src/mojo/public/cpp/bindings/binding.h
+++ b/third_party/mojo/src/mojo/public/cpp/bindings/binding.h
@@ -50,11 +50,11 @@ namespace mojo {
// waiting for calls to arrive. Normally it is fine to use the default waiter.
// However, the caller may provide their own implementation if needed. The
// |Binding| will not take ownership of the waiter, and the waiter must outlive
-// the |Binding|.
-//
-// TODO(ggowan): Find out under what circumstances the caller may need to
-// provide their own implementation of MojoAsyncWaiter, and then describe those
-// circumstances.
+// the |Binding|. The provided waiter must be able to signal the implementation
+// which generally means it needs to be able to schedule work on the thread the
+// implementation runs on. If writing library code that has to work on different
+// types of threads callers may need to provide different waiter
+// implementations.
template <typename Interface>
class Binding : public ErrorHandler {
public:
@@ -106,7 +106,7 @@ class Binding : public ErrorHandler {
}
// Completes a binding that was constructed with only an interface
- // implementation. Takes ownership of |handle| and binds it to the previously
+ // implementation. Takes ownership of |handle| and binds it to the previously
// specified implementation. See class comment for definition of |waiter|.
void Bind(
ScopedMessagePipeHandle handle,

Powered by Google App Engine
This is Rietveld 408576698